Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab-ce: 12.0.3 -> 12.1.6 #66621

Merged
merged 5 commits into from Aug 18, 2019

Conversation

@flokli
Copy link
Contributor

commented Aug 14, 2019

This bumps gitlab to its latest version (12.1.6), also containing some important security fixes.
On top of that, we stop shipping the 1.3GiB gitlab-deb-data.tar file in $out ;-)

Motivation for this change

https://about.gitlab.com/2019/08/12/critical-security-release-gitlab-12-dot-1-dot-6-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lheckemann @talyz

flokli added some commits Aug 14, 2019

gitlab: remove gitlab-deb-data.tar after extracting from it
There's no reason to ship a 1.6GiB .tar file in the output.
Slims down that output from 1.9GiB to ~350MiB

@flokli flokli requested review from fpletz and globin Aug 14, 2019

@flokli flokli referenced this pull request Aug 14, 2019
5 of 10 tasks complete
@adisbladis

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

@GrahamcOfBorg test gitlab

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

@GrahamcOfBorg build gitlab gitaly gitlab-ee

@flokli flokli merged commit 36ece76 into NixOS:master Aug 18, 2019

17 of 18 checks passed

gitaly, gitlab, gitlab-ee on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
gitaly, gitlab, gitlab-ee on aarch64-linux Success
Details
gitaly, gitlab, gitlab-ee on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.gitlab on aarch64-linux Success
Details
tests.gitlab on x86_64-linux Success
Details

@flokli flokli deleted the flokli:gitlab-12.1.6 branch Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.