Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lv: init at 4.51 #66629

Open
wants to merge 2 commits into
base: master
from

Conversation

@kayhide
Copy link

commented Aug 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@@ -2700,6 +2700,11 @@
email = "info+nix@chmist.com";
name = "karolchmist";
};
kayhide = {

This comment has been minimized.

Copy link
@mmahut

mmahut Aug 15, 2019

Member

Please submit this as a separate commit.

This comment has been minimized.

Copy link
@kayhide

kayhide Aug 15, 2019

Author

@mmahut Okay, I have done it! Please take a look.

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@GrahamcOfBorg build lv

@kayhide kayhide force-pushed the kayhide:add/lv branch from 0b873b8 to d4010f8 Aug 15, 2019

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

@GrahamcOfBorg build lv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.