Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmit: 1.1.14 -> 1.2.6 #66633

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@jonringer
Copy link
Contributor

commented Aug 14, 2019

Motivation for this change

fixing updates @r-ryantm cannot

also, fixed executable about wrapping Qt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
1 package were build:
fmit

The large increase is because Qt is now properly included in the closure.

$ nix path-info -Sh ./result
/nix/store/98vv44jpnymqmbx5b6galwg117dvg3l3-fmit-1.2.6   406.5M
$ nix path-info -Sh ./result
/nix/store/pg3f03yh62xrpz3zqz8q8l41n872j3x3-fmit-1.1.14  207.1M

previous execution error:

$ ./result/bin/fmit
Free Music Instrument Tuner (Version 1.1.14-)
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@GrahamcOfBorg build fmit

@symphorien

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

Ran nix-review, the alsa backend works fine (the qt one does not but it's probably because I do not use plasma)

@mmahut

mmahut approved these changes Aug 15, 2019

Copy link
Member

left a comment

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@mmahut mmahut merged commit aba586a into NixOS:master Aug 15, 2019

15 of 16 checks passed

fmit on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
fmit on aarch64-linux Success
Details
fmit on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@jonringer jonringer deleted the jonringer:bump-fmit branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.