Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tusk: init at v0.23.0 #66710

Merged
merged 1 commit into from Jan 8, 2020
Merged

tusk: init at v0.23.0 #66710

merged 1 commit into from Jan 8, 2020

Conversation

@tbenst
Copy link
Contributor

@tbenst tbenst commented Aug 16, 2019

Motivation for this change

add Tusk AppImage package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tbenst tbenst force-pushed the tbenst:tusk branch from 6eb19c1 to 99ab5d7 Aug 16, 2019
@tbenst
Copy link
Contributor Author

@tbenst tbenst commented Aug 16, 2019

would help if I added the files :D. Should be good to go now

@tbenst tbenst force-pushed the tbenst:tusk branch from 99ab5d7 to 8cc40d7 Aug 18, 2019
@tbenst
Copy link
Contributor Author

@tbenst tbenst commented Aug 18, 2019

@mmahut thx for review, all requested changes made

Copy link
Contributor

@aanderse aanderse left a comment

@tbenst 2 minor changes, if you don't mind. I haven't worked with appimage on nixos yet, but this looks relatively straight forward. 👍

pkgs/applications/office/tusk/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/tusk/default.nix Outdated Show resolved Hide resolved
@tbenst tbenst force-pushed the tbenst:tusk branch from 8cc40d7 to b8700b4 Aug 31, 2019
@tbenst
Copy link
Contributor Author

@tbenst tbenst commented Aug 31, 2019

@aanderse thx! changes made.

Do you happen to know how to add app name / icon to the lauancher? Fully functional but requires typing "tusk" at cmd line vs using eg KDE launcher

@aanderse
Copy link
Contributor

@aanderse aanderse commented Aug 31, 2019

Do you happen to know how to add app name / icon to the lauancher? Fully functional but requires typing "tusk" at cmd line vs using eg KDE launcher

This looks like a reasonable example to work from.

@tbenst
Copy link
Contributor Author

@tbenst tbenst commented Sep 4, 2019

Thanks! I'll give this a look next week or so, away from my NixOS box and on too poor an internet connection right now to test GUI stuff

@tbenst tbenst force-pushed the tbenst:tusk branch from b8700b4 to 0ca0fc9 Dec 12, 2019
@tbenst
Copy link
Contributor Author

@tbenst tbenst commented Dec 12, 2019

@aanderse thanks for tip, worked beautifully. Ready for final review

@tbenst tbenst force-pushed the tbenst:tusk branch from 0ca0fc9 to 2e39c74 Dec 12, 2019
@aanderse
Copy link
Contributor

@aanderse aanderse commented Dec 15, 2019

Thanks @tbenst! Did anyone (@mmahut, me?) test this yet?

@tbenst
Copy link
Contributor Author

@tbenst tbenst commented Jan 7, 2020

@aanderse I've been using it for a couple weeks with no issues!

@tbenst tbenst force-pushed the tbenst:tusk branch from 2e39c74 to 0dd8ee7 Jan 8, 2020
@tbenst
Copy link
Contributor Author

@tbenst tbenst commented Jan 8, 2020

@aanderse fixed the trailing 'i'--a vim insert ;)

@aanderse
Copy link
Contributor

@aanderse aanderse commented Jan 8, 2020

Sorry this took forever. Thanks for contributing the package! 🎉

@aanderse aanderse merged commit 24967c1 into NixOS:master Jan 8, 2020
15 checks passed
15 checks passed
tusk on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tusk on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.