Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: 2.22.0 -> 2.23.0 #66773

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@Izorkin
Copy link
Contributor

commented Aug 17, 2019

Motivation for this change

Update git to version 2.23.0
Changelog - https://lkml.org/lkml/2019/8/16/877

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

@GrahamcOfBorg build git
@GrahamcOfBorg test gitolite

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

This should probably go to staging as a mass rebuild, please.

@wmertens wmertens changed the base branch from master to staging Aug 18, 2019
@wmertens wmertens changed the base branch from staging to master Aug 18, 2019
@wmertens

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

@Izorkin I tried changing the base but it picked up changes in 54 other files ;) LGTM, can you rebase on staging?

@Izorkin Izorkin force-pushed the Izorkin:git branch from a8967f9 to 6da7a17 Aug 18, 2019
@Izorkin Izorkin requested review from alyssais and FRidh as code owners Aug 18, 2019
@FRidh FRidh added this to the 19.09 milestone Aug 18, 2019
@ttuegel ttuegel removed their request for review Aug 18, 2019
@peti peti merged commit 59d3b6e into NixOS:staging Aug 21, 2019
16 of 18 checks passed
16 of 18 checks passed
git on x86_64-darwin Timed out, unknown build status
Details
tests.gitolite on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
git on aarch64-linux Success
Details
git on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.gitolite on aarch64-linux Success
Details
@Izorkin Izorkin deleted the Izorkin:git branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.