Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains.mps: init at 2019.2 #66824

Merged
merged 2 commits into from Jun 1, 2020
Merged

Conversation

@rasendubi
Copy link
Member

rasendubi commented Aug 18, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edwtjo

@rasendubi
Copy link
Member Author

rasendubi commented Aug 27, 2019

MPS-2019.2 has been released yesterday. It now supports jbr11, so the expression is simpler now.

@rasendubi rasendubi force-pushed the rasendubi:jetbrains-mps-2019.1.5 branch from cee1572 to cc1fcec Aug 27, 2019
@rasendubi rasendubi changed the title jetbrains.mps: init at 2019.1.5 jetbrains.mps: init at 2019.2 Aug 28, 2019
@rasendubi
Copy link
Member Author

rasendubi commented Aug 28, 2019

Ping other JetBrains co-maintainers @edwtjo @Mic92 @loskutov @miltador.
Could you please review the PR?

The package works fine for me on NixOS with sandboxing. The part I am not sure about is the download link: it is different from other product and includes major version twice (e.g., for 2019.1.5 it is https://download.jetbrains.com/mps/2019.1/MPS-2019.1.5.tar.gz). I think this should work fine with the package updated, but I'll need to bump the major version manually once in a while.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.
@stale stale bot added the 2.status: stale label Jun 1, 2020
@Mic92
Copy link
Contributor

Mic92 commented Jun 1, 2020

Result of nixpkgs-review pr 66824 1

1 package built:
- jetbrains.mps
@Mic92 Mic92 merged commit 59aacec into NixOS:master Jun 1, 2020
16 checks passed
16 checks passed
jetbrains.mps on aarch64-linux No attempt
Details
jetbrains.mps on x86_64-darwin No attempt
Details
jetbrains.mps on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@stale stale bot removed the 2.status: stale label Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.