Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/samba: add option reloadIfchanged #66889

Closed
wants to merge 1 commit into from

Conversation

@tw-360vier
Copy link
Contributor

commented Aug 19, 2019

This helps prevent client disconnects during configuration update.

Motivation for this change

Enable updating the samba configuration while the service is in use.

Things done

Manually tested the reloadIfChanged option.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This helps prevent client disconnects during configuration update.
@gloaming

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Do you really need to prevent all of the samba services from restarting?

If it's just smbd, it should be sufficient to set
systemd.services.samba-smbd.reloadIfChanged = true;
in configuration.nix.

@tw-360vier

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Hmm yeah seems you're right. Thank you!

@tw-360vier tw-360vier closed this Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.