Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gofumpt: Init at 2019-07-29 #66892

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@rvolosatovs
Copy link
Contributor

rvolosatovs commented Aug 19, 2019

Motivation for this change

New package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rvolosatovs

This comment has been minimized.

Copy link
Contributor Author

rvolosatovs commented Aug 19, 2019

@GrahamcOfBorg build gofumpt


modSha256 = "1g7dkl60zwlk4q2gwx2780xys8rf2c4kqyy8gr99s5y342wsbx2g";

meta = with lib; {

This comment has been minimized.

Copy link
@symphorien

symphorien Aug 19, 2019

Contributor

can you add a description ?

This comment has been minimized.

Copy link
@rvolosatovs

rvolosatovs Aug 20, 2019

Author Contributor

done!

@rvolosatovs rvolosatovs force-pushed the rvolosatovs:init/gofumpt branch from 40a4389 to 29bc556 Aug 20, 2019
{ lib, buildGoModule, fetchFromGitHub }:

buildGoModule rec {
name = "gofumpt-${version}";

This comment has been minimized.

Copy link
@alexarice

alexarice Aug 20, 2019

Contributor

Can you use pname = "gofumpt"; here instead?


src = fetchFromGitHub {
owner = "mvdan";
repo = "gofumpt";

This comment has been minimized.

Copy link
@alexarice

alexarice Aug 20, 2019

Contributor

repo = pname;

@rvolosatovs

This comment has been minimized.

Copy link
Contributor Author

rvolosatovs commented Aug 26, 2019

@alexarice done!

@rvolosatovs rvolosatovs force-pushed the rvolosatovs:init/gofumpt branch from 29bc556 to 4d30eb6 Aug 26, 2019
@rvolosatovs

This comment has been minimized.

Copy link
Contributor Author

rvolosatovs commented Aug 26, 2019

@GrahamcOfBorg build gofumpt

@kalbasit kalbasit merged commit 3f4144c into NixOS:master Aug 26, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gofumpt on aarch64-linux Success
Details
gofumpt on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@rvolosatovs rvolosatovs deleted the rvolosatovs:init/gofumpt branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.