Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sampler: init at 1.0.3 #67036

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@uvNikita
Copy link
Contributor

commented Aug 20, 2019

Motivation for this change

Sampler is a tool for a simple monitoring and alerting in console with ASCII graphics.
See https://github.com/sqshq/sampler.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

pkgs/applications/misc/sampler/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/sampler/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/sampler/default.nix Outdated Show resolved Hide resolved
@uvNikita uvNikita force-pushed the uvNikita:sampler branch from 804c6ec to d8ec5dc Aug 20, 2019
@uvNikita

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

@srhb Thanks for the review! Fixed.

pkgs/applications/misc/sampler/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/sampler/default.nix Outdated Show resolved Hide resolved
description = "Tool for shell commands execution, visualization and alerting";
homepage = "https://sampler.dev";
license = licenses.gpl3;
maintainers = with maintainers; [ uvnikita ];

This comment has been minimized.

Copy link
@alexarice

alexarice Aug 20, 2019

Contributor

Do go modules usually have a platforms meta field?

This comment has been minimized.

Copy link
@uvNikita

uvNikita Aug 21, 2019

Author Contributor

I've added platforms = platforms.unix since windows support seems to be experimental: https://github.com/sqshq/sampler#windows-experimental

@srhb
srhb approved these changes Aug 21, 2019
@uvNikita uvNikita force-pushed the uvNikita:sampler branch from d8ec5dc to 1104a97 Aug 21, 2019
@srhb

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

@GrahamcOfBorg build sampler

@srhb srhb merged commit 078f7c0 into NixOS:master Aug 21, 2019
15 of 16 checks passed
15 of 16 checks passed
sampler on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sampler on aarch64-linux Success
Details
sampler on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.