Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.hakyll: patch Cabal file from upstream #67065

Closed

Conversation

@erictapen
Copy link
Contributor

commented Aug 20, 2019

Continuation of #66833.

Hakyll complains about our QuickCheck version being too high. Upstream
solved that problem already, so let's use that patch.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

hakyll complains about our QuickCheck version being too high. Upstream
solved that problem already, so let's use that patch [0].

[0] jaspervdj/hakyll#721
@erictapen erictapen requested a review from basvandijk as a code owner Aug 20, 2019
@worldofpeace worldofpeace requested review from peti and Infinisil and removed request for peti Aug 20, 2019
@peti peti changed the base branch from master to haskell-updates Aug 21, 2019
@peti peti force-pushed the NixOS:haskell-updates branch from ea4dc88 to f8f09d2 Aug 21, 2019
peti added a commit that referenced this pull request Aug 21, 2019
hakyll complains about our QuickCheck version being too high. Upstream
solved that problem already, so let's use that patch [0].

Closes #67065.

[0] jaspervdj/hakyll#721
peti added a commit that referenced this pull request Aug 21, 2019
hakyll complains about our QuickCheck version being too high. Upstream
solved that problem already, so let's use that patch [0].

Closes #67065.

[0] jaspervdj/hakyll#721
@peti peti force-pushed the NixOS:haskell-updates branch from d67b63d to 70cc3ba Aug 21, 2019
@peti peti force-pushed the NixOS:haskell-updates branch from f28287a to 8a9b00f Aug 21, 2019
@peti peti closed this in fe366d4 Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.