Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libv4l: disable building Qt #67134

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@jtojnar
Copy link
Contributor

commented Aug 20, 2019

Since we added wrapQTAppHooks to qt5.mkDerivation, it pollutes the closure of everything it touches even when package is not building with QT support.

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Hmm, this is an interesting topic. When there's optional qt features I'd expect people to add wrapQtAppsHook manually and to not use qt5.mkDerivation.

@jtojnar jtojnar changed the title qt5.mkDerivation: allow disabling hook insertion libv4l: disable building Qt Aug 20, 2019
@jtojnar jtojnar force-pushed the jtojnar:origin/staging branch from c765bd6 to b7f6873 Aug 20, 2019
Copy link
Member

left a comment

Should work as intended.

pkgs/os-specific/linux/v4l-utils/default.nix Outdated Show resolved Hide resolved
Since we added wrapQTAppHooks to qt5.mkDerivation, it pollutes the closure
of everything it touches even when package is not building with Qt support.
We had to revert to the standard deriver to avoid this.
@jtojnar jtojnar force-pushed the jtojnar:origin/staging branch from b7f6873 to 565a1c8 Aug 21, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Huh, this is only 101-500 rebuilds according to ofborg. Should we go to master?

@jtojnar

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

There would be a merge conflict.

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Ah, merging then.

@worldofpeace worldofpeace merged commit e6e03ba into NixOS:staging Aug 21, 2019
8 of 10 checks passed
8 of 10 checks passed
grahamcofborg-eval Beginning Evaluations
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar jtojnar deleted the jtojnar:origin/staging branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.