Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libosinfo packages #67147

Merged
merged 3 commits into from Aug 23, 2019

Conversation

@jonringer
Copy link
Contributor

commented Aug 21, 2019

Motivation for this change

noticed osinfo-db-tools wasn't able to be updated by @r-ryantm

Edit:
closes #67004

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bjornfor

@jonringer jonringer changed the title Bump osinfo Bump libosinfo packages Aug 21, 2019
@ofborg ofborg bot requested a review from bjornfor Aug 21, 2019
@worldofpeace worldofpeace self-requested a review Aug 21, 2019
@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@GrahamcOfBorg build libosinfo osinfo-db osinfo-db-tools

@jonringer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

looks like there was a regression in the xen package, hold off merging for now :(

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

I can fix that @jonringer, I actually had this on my todo list so thanks for picking it up 👍

@jonringer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

hmmm, gnome3.boxes virtmanager both seem to fail because xen isn't able to be built, however, that seems to be broken by glusterfs being bumped to >=6. How these packages are still able to be built on master, I have no idea.

Also, seeing that i can't check the derivation, I'm not sure if it's possible to actually build xen on master

these derivations will be built:
  /nix/store/cikgf51va5gjhdmy91kcj2cf9zhxl73k-xen-4.8.3.drv
error: some outputs of '/nix/store/cikgf51va5gjhdmy91kcj2cf9zhxl73k-xen-4.8.3.drv' are not valid, so checking is not possible
@jonringer jonringer force-pushed the jonringer:bump-osinfo branch from 2ec68d0 to a4337c6 Aug 21, 2019
@jonringer jonringer force-pushed the jonringer:bump-osinfo branch from a4337c6 to 08aa1b7 Aug 21, 2019
@jonringer jonringer force-pushed the jonringer:bump-osinfo branch from 08aa1b7 to 038fbf0 Aug 21, 2019
@jtojnar

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Looks good, thanks.

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

@GrahamcOfBorg build libosinfo osinfo-db osinfo-db-tools

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Thank you all.

@mmahut mmahut merged commit 29ca909 into NixOS:master Aug 23, 2019
15 of 16 checks passed
15 of 16 checks passed
libosinfo, osinfo-db, osinfo-db-tools on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libosinfo, osinfo-db, osinfo-db-tools on aarch64-linux Success
Details
libosinfo, osinfo-db, osinfo-db-tools on x86_64-linux Success
Details
@jonringer jonringer deleted the jonringer:bump-osinfo branch Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.