Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.DBDOracle: 1.76 -> 1.80 #67148

Closed
wants to merge 1 commit into from

Conversation

@aanderse
Copy link
Contributor

commented Aug 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth - would this update automatically, or is that just packages in top-level/perl-packages.nix?

@volth

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

cc @volth - would this update automatically, or is that just packages in top-level/perl-packages.nix?

Only top-level/perl-packages.nix
I think those 4-5 CPAN packages have to be moved into top-level/perl-packages.nix to simplify update

@flokli

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

This also should be rebased once #67206 is merged (which changed the oracle-instantclient derivation to be have multiple outputs.

@aanderse

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

Closing in favor of #67206 ❤️ @flokli

@aanderse aanderse closed this Aug 22, 2019
@aanderse aanderse deleted the aanderse:dbd-oracle branch Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.