Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt-viewer: remove unused packages #67177

Merged
merged 2 commits into from Aug 29, 2019

Conversation

@Izorkin
Copy link
Contributor

commented Aug 21, 2019

Motivation for this change

Smaller closure and remove unused packages.
Checked on the home server - virt-viewer worked. Libvirt builded with xen support.
There is no way to check connect to the xen server

@jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@GrahamcOfBorg build virt-viewer

@jtojnar

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Relevant PRs:

cc @globin @volth

@Izorkin Izorkin force-pushed the Izorkin:virt-viewer branch from 381872c to 8f88573 Aug 25, 2019
@Izorkin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

@GrahamcOfBorg build virt-viewer

@Izorkin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@7c6f434c

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

@Izorkin eval seems to have failed

@Izorkin Izorkin force-pushed the Izorkin:virt-viewer branch from 8f88573 to 6b66d76 Aug 29, 2019
@Izorkin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

On the home server command nix-env -f ./default.nix -qaP correct work

@Izorkin Izorkin force-pushed the Izorkin:virt-viewer branch from 6b66d76 to d833433 Aug 29, 2019
@Izorkin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

@7c6f434c fixed.

Izorkin added 2 commits Aug 20, 2019
@globin globin force-pushed the Izorkin:virt-viewer branch from d833433 to 4471efd Aug 29, 2019
@globin globin merged commit cbd4d59 into NixOS:master Aug 29, 2019
1 check was pending
1 check was pending
grahamcofborg-eval Cloning project
Details
@Izorkin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

@globin

  nativeBuildInputs = [ pkgconfig intltool vala gobject-introspection ];
  buildInputs = [ libcap_ng libvirt libxml2 gobject-introspection ];

gobject-introspection - dublicate

@globin

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Yes, it has to be in both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.