Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsl: 2.5 -> 2.6 #67182

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@lsix
Copy link
Member

commented Aug 21, 2019

See https://lists.gnu.org/archive/html/info-gnu/2019-08/msg00004.html
for release announcement

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@markuskowa

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@GrahamcOfBorg build gsl
@GrahamcOfBorg build octopus
@GrahamcOfBorg build luminanceHdr

Copy link
Member

left a comment

Are the two platform specific bug fixes mentioned alongside NIX_CFLAGS_COMPILE and doCheck still required?

@markuskowa markuskowa self-assigned this Aug 21, 2019
@lsix

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

I did not see in the changelog reasons to think those are not required anymore, but I have to admit I did not test without those…

I’ll investigate further into this (given that I only have a x86_64 machine available, I will not be able to test for other platforms)

@markuskowa

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

I’ll investigate further into this (given that I only have a x86_64 machine available, I will not be able to test for other platforms)

If you want to test if the doCheck works on aarch64, you could use OfBorg.

Copy link
Member

left a comment

The nix-review looks good. I can not see any build failures that I could attribute to the gsl update.

@lsix

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

I removed the checks NIX_CFLAGS_COMPILE and doCheck instructions to see how it works (in a WIP independant commit).

@GrahamcOfBorg build gsl

@lsix lsix changed the title gsl: 2.5 -> 2.6 [WIP] gsl: 2.5 -> 2.6 Aug 21, 2019
@lsix lsix force-pushed the lsix:gsl-2.6 branch from ff16a71 to fcf62b7 Aug 21, 2019
@lsix

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

@GrahamcOfBorg build gsl

@lsix lsix force-pushed the lsix:gsl-2.6 branch from fcf62b7 to cb02fca Aug 21, 2019
@lsix

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

The doCheck constraint needs to remain as it is.

We can properly build without disabling fma, but I’d prefer to leave it as it is for consistency.

@lsix lsix changed the title [WIP] gsl: 2.5 -> 2.6 gsl: 2.5 -> 2.6 Aug 21, 2019
@markuskowa markuskowa merged commit e438346 into NixOS:staging Aug 21, 2019
16 of 25 checks passed
16 of 25 checks passed
gsl on x86_64-darwin Timed out, unknown build status
Details
luminance-hdr on aarch64-linux No attempt
Details
luminance-hdr on x86_64-darwin No attempt
Details
luminance-hdr on x86_64-linux No attempt
Details
luminanceHdr on aarch64-linux No attempt
Details
luminanceHdr on x86_64-darwin No attempt
Details
luminanceHdr on x86_64-linux No attempt
Details
octopus on aarch64-linux No attempt
Details
octopus on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
gsl on aarch64-linux Success
Details
gsl on x86_64-linux Success
Details
octopus on x86_64-linux Success
Details
@markuskowa

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Thanks for double checking the fixes!

@lsix lsix deleted the lsix:gsl-2.6 branch Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.