Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MythTV 29.1 -> 30.0 #67191

Closed
wants to merge 0 commits into from

Conversation

@LouisDK1
Copy link
Contributor

commented Aug 21, 2019

Motivation for this change

#54596

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Jonathan Rudenberg jonathan@titanous.com

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

@GrahamcOfBorg build mythtv

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

@titanous @LouisDK1 please see the build failures.

@LouisDK1

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@mmahut will look into this tomorrow.

@LouisDK1

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

As new dependencies are introduced in 30.0 the configure file is updated with some unpure hacks. I'll patch this and make a new commit before the end of the weekend.

@LouisDK1

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

Important before merging:

I need to somehow to detect if mythtv is being build on a system using some "nvidia*" driver and if not mythtv should be build with "--disable-xnvctrl" as an additional configureFlags.
This could be done with some .override option. Just need to figure out how to do this.

Also line 6673 should be commented to avoid build errors. I'll patch that after the above has been solved.

@LouisDK1

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

The problem is that building fails on my intel-only system due to xnvctrl not being present. Is it correct that this would too happen on a nvidia system because the building is done inside a sandbox?

If yes maybe I should just disable xnvctrl by default.

Update: Shouldn't fail on an nvidia system if the driver is loaded as buildInputs on an nvidia system right?

@ck3d
ck3d approved these changes Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.