Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs-test: Allow overriding kernel packages #67203

wants to merge 1 commit into
base: master


Copy link

commented Aug 21, 2019

Motivation for this change

This lets end-users override the kernel package used in the test with the one their system is (going to) run, hence confirming that it'll still be able to boot. Since the most common cause of ZFS boot failures is Linux kernel incompatibilities, testing against a different kernel than is booted has only limited usefulness.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @Ekleog


This comment has been minimized.

Copy link

commented Sep 8, 2019

@@ -1,5 +1,5 @@
{ system ? builtins.currentSystem,
config ? {},
config ? { boot.kernelPackages = pkgs.linuxPackages_latest; },
pkgs ? import ../.. { inherit system config; }

This comment has been minimized.

Copy link

Infinisil Sep 20, 2019


I think this should be a separate argument. The config here doesn't have anything to do with a NixOS configuration. Something like

{ system ? builtins.currentSystem
, config ? {}
, pkgs ? import ../.. { inherit system config; }
, kernelPackages ? pkgs.linuxPackages_latest }: null

This comment has been minimized.

Copy link

Baughn Sep 20, 2019

Author Contributor

The purpose of doing this was precisely to let users (e.g. me) pass a NixOS configuration in. You can do that with a fair number of other tests, and it's basically the main reason to run tests locally.

Ideally I'd like to make it work for all of them, with the same interface, letting me add a --run-tests option to nixos-rebuild.

This comment has been minimized.

Copy link

Infinisil Sep 20, 2019


I don't see any test using the nixpkgs config as a NixOS config? They all pass it to import <nixpkgs> { inherit config; }, where a NixOS config makes no sense at all.

If you want it to support passing in arbitrary NixOS configs you need to do something like this:

{ nixosConfiguration ? {}
, ...
  kernelPackages = (import ../../nixos {
    configuration = nixosConfiguration;
in ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.