Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adoptopenjdk-icedtea-web: rename from icedtea_web #67214

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@stefano-m
Copy link
Contributor

commented Aug 21, 2019

Motivation for this change

This is a follow up of #66422

  • rename icedtea_web to adoptopenjdk-icedtea-web to reflect the new governance
  • add icedtea_web and icedtea8_web to aliases.nix for backwards compatibility
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace (who reviewed #66422)

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

We need to rename the references within nixpkgs as well.

This was the only one

pkgs/applications/networking/browsers/firefox/wrapper.nix
6:, jrePlugin, icedtea_web
58:          ++ lib.optional icedtea icedtea_web

Also, I think a more descriptive commit msg would be

adoptopenjdk-icedtea-web: rename from icedtea_web
@stefano-m

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

We need to rename the references within nixpkgs as well.

Thanks, I'll fix that.

@stefano-m

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

force-pushed to fix the little mess I made

@stefano-m

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

FTR, I wonder whether it still makes sense to keep icedtea-web in firefox since support for Java plugins has been removed in version 52.0 (released on 7th of March 2017)?

@stefano-m

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

One could technically try to build firefox-esr-52 with icedtea support, but the package is marked as insecure, so before doing

nix-build -I nixpkgs=./ -E 'with import <nixpkgs> { }; wrapFirefox firefox-esr-52-unwrapped { cfg = {icedtea = true;}; }'

they would also need to add

  permittedInsecurePackages = [
    "firefox-52.9.0esr"
    "firefox-esr-unwrapped-52.9.0esr"
  ];

To their nix/nixos configuration.

@ofborg ofborg bot requested a review from wizeman Aug 21, 2019
@worldofpeace worldofpeace changed the title adoptopenjdk-icedtea-web: init at 1.8.3 adoptopenjdk-icedtea-web: rename from icedtea_web Aug 22, 2019
This is a follow up of #66422

- rename icedtea_web to adoptopenjdk-icedtea-web to reflect the new governance
- add icedtea_web and icedtea8_web to aliases.nix for backwards compatibility
- update the attribute name where icedtea_web is used
@worldofpeace worldofpeace merged commit 0552f4d into NixOS:master Aug 23, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Thanks for following up @stefano-m

@vcunat

This comment has been minimized.

This changed rev to something that doesn't exist in the repo. "Fortunately" the line ended in a conflict which I noticed and fixed within conflict resolution in 2e6bf42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.