Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackage.cohttp: 2.0.0 -> 2.1.3 #67218

Merged
merged 2 commits into from Aug 22, 2019

Conversation

@vbgl
Copy link
Contributor

commented Aug 21, 2019

Motivation for this change

cohttp has been broken by #67008 This update fixes it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
vbgl added 2 commits Aug 21, 2019
@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

@GrahamcOfBorg build ocamlPackages.cohttp

@vbgl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@GrahamcOfBorg build ocamlPackages.git-unix ocamlPackages.opium

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Looks good, thank you @vbgl.

@mmahut mmahut merged commit 17a2721 into NixOS:master Aug 22, 2019
19 of 22 checks passed
19 of 22 checks passed
ocamlPackage.cohttp on aarch64-linux No attempt
Details
ocamlPackage.cohttp on x86_64-darwin No attempt
Details
ocamlPackage.cohttp on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocamlPackages.cohttp on aarch64-linux Success
Details
ocamlPackages.cohttp on x86_64-darwin Success
Details
ocamlPackages.cohttp on x86_64-linux Success
Details
ocamlPackages.git-unix, ocamlPackages.opium on aarch64-linux Success
Details
ocamlPackages.git-unix, ocamlPackages.opium on x86_64-darwin Success
Details
ocamlPackages.git-unix, ocamlPackages.opium on x86_64-linux Success
Details
@vbgl vbgl deleted the vbgl:ocaml-uri-sexp-3.0.0 branch Aug 22, 2019
@vbgl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

ping @ryantm

@ryantm

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

@vbgl what's up?

@vbgl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

Just in case you wanted to apologize for causing such a mess and tell us what you intend to do to ensure it will not happen again in the future.

@ryantm

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Oh, sorry, I didn't see the first sentence of the PR.

It is interesting that the "rebuild report" for #67008 doesn't list ocamlPackage.cohttp. nixpkgs-update is using pretty much the exact same thing that OfBorg uses for determining the number of packages that changed. It also looks like nix-review must not be detecting the dependency.

@ryantm

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Oh, I see what is wrong. The definition of cohttp is dependent on the version of ocaml and in the case where the ocaml version is greater than or equal to 4.03 it used cohttp_p4, which doesn't depend on uri, but rather depends on uri_p4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.