Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add large hunspell dicts #67424

Merged
merged 2 commits into from Sep 3, 2019
Merged

Add large hunspell dicts #67424

merged 2 commits into from Sep 3, 2019

Conversation

@Provessor
Copy link
Contributor

Provessor commented Aug 25, 2019

Motivation for this change

Larger dictionary options for American, Canadian and Australian English

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Aug 25, 2019

Can you please squash your commits and include the package name in the commit message, as asked in https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md ?

…ctionaries

Squashed commit of the following:

commit e3c0054
Author: Jai Flack <jaiflack@protonmail.com>
Date:   Tue Aug 27 18:38:34 2019 +1000

    Add en_GB-large, en_US-large, en_CA-large and en_AU-large hunspell
    dictionaries

    Squashed commit of the following:

    commit 6b16e73
    Author: Jai Flack <jaiflack@protonmail.com>
    Date:   Sun Aug 25 15:38:08 2019 +1000

        Adding en_GB-large dictionary

    commit c94c6c3
    Author: Jai Flack <jaiflack@protonmail.com>
    Date:   Sun Aug 25 15:37:37 2019 +1000

        Fix en_US-large and en_CA-large hashes

    commit 84a847b
    Author: Jai Flack <jaiflack@protonmail.com>
    Date:   Sun Aug 25 15:15:54 2019 +1000

        Adding en_AU-large dictionary

    commit b7d6e1c
    Author: Jai Flack <jaiflack@protonmail.com>
    Date:   Sun Aug 25 15:15:36 2019 +1000

        Adding en_CA-large dictionary

    commit c1857a6
    Author: Jai Flack <jaiflack@protonmail.com>
    Date:   Sun Aug 25 15:15:10 2019 +1000

        Adding en_US-large dictionary

    commit 898caa0
    Author: Jai Flack <jaiflack@protonmail.com>
    Date:   Sun Aug 25 15:14:25 2019 +1000

        Modifying mkDictFromWordlist to allow for different src and destination
        file names
@Provessor

This comment has been minimized.

Copy link
Contributor Author

Provessor commented Aug 27, 2019

How's this @mmahut?
I can't find how to squash the first commit with the rest (I've tried twice as you can see in the commit history). If you could point me in the right direction with anything else that needs to be done, I'll get on it.

@aristidb aristidb merged commit cac6631 into NixOS:master Sep 3, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Provessor Provessor deleted the Provessor:add-large-hunspell-dicts branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.