Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiv2: 0.27.1 -> 0.27.2 #67453

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@mmahut
Copy link
Member

commented Aug 25, 2019

Motivation for this change

Fixes #67194

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes #67194
@mmahut

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

@GrahamcOfBorg build empathy

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

I have

    # Fix tests on Aarch64

in the expression. Can we check if that's fixed?

@mmahut

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

Can we check if that's fixed?

It looks like it does, yay.

@mmahut

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

Did a full rebuild over night, no new broken packages.

@mmahut mmahut merged commit 3052cc1 into NixOS:master Aug 26, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
exiv2 on aarch64-linux Success
Details
exiv2 on x86_64-darwin Success
Details
exiv2 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

Did a full rebuild over night, no new broken packages.

Excellent, thanks 👍

@@ -58,8 +53,6 @@ stdenv.mkDerivation rec {
"doc"
];

doCheck = stdenv.isLinux;

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Aug 26, 2019

Member

doCheck is default false so this disabled them.

This comment has been minimized.

Copy link
@mmahut

mmahut Aug 26, 2019

Author Member

Oh :(

mmahut added a commit to mmahut/nixpkgs that referenced this pull request Aug 26, 2019
@mmahut mmahut referenced this pull request Aug 26, 2019
0 of 10 tasks complete
peterhoeg added a commit to peterhoeg/nixpkgs that referenced this pull request Aug 27, 2019
@ckauhaus ckauhaus referenced this pull request Sep 12, 2019
0 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.