Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: enable loadable sqlite extensions #67472

Merged
merged 1 commit into from Aug 31, 2019

Conversation

@matthewbauer
Copy link
Member

commented Aug 26, 2019

Our sqlite supports it, so might as well make use of it.

Fixes #66526

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@teto
teto approved these changes Aug 26, 2019
@FRidh

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

The modified file is only used by Python 3.

@matthewbauer

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

The modified file is only used by Python 3.

I think this only works on python 3:

https://bugs.python.org/issue10268

@artemist

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

Now that you've changed the base to staging, can you cherry-pick your commit onto origin/staging and force push back here? That should clean up the merge conflicts and make GitHub a lot less mad when trying to view differences.

Our sqlite supports it, so might as well make use of it.

Fixes #66526
@disassembler disassembler force-pushed the matthewbauer:fix-66526 branch from 5c6a536 to 70f2174 Aug 31, 2019
@disassembler disassembler merged commit 98662eb into NixOS:staging Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.