Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botan2: 2.7 -> 2.11 #67480

Open
wants to merge 2 commits into
base: master
from

Conversation

@jonringer
Copy link
Contributor

commented Aug 26, 2019

Motivation for this change

fixing @r-ryantm updates

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

powerdns is broken on master:

[3 built (1 failed), 88 copied (2618.7 MiB), 240.2 MiB DL]
error: build of '/nix/store/w9yyvmc9a6vpcqr9c5vi37c518b0f1wg-env.drv' failed
1 package failed to build:
powerdns

4 package were build:
biboumi botan2 kea neopg
@peterhoeg

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

@GrahamcOfBorg build botan2

@jonringer jonringer force-pushed the jonringer:bump-botan2 branch from ea844a4 to 6265a32 Aug 26, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

rebased off master to fix trace: warning: builtPerlPackage: name' ("Device-SerialPort-1.04") is deprecated, use pname' and version' instead` breaking grahamofborg

@peterhoeg

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

Yep, that was my mistake. Apologies.

@peterhoeg

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

If GH is the proper upstream, I suggest dropping the multiple sources and replace fetchurl with fetchFromGitHub.

@jonringer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@GrahamcOfBorg build botan botan2

@jonringer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

im getting a regression with the neopg package. Hold off merging for now. :(

@jonringer jonringer force-pushed the jonringer:bump-botan2 branch from c8a5f5b to 3e600f9 Oct 3, 2019
@jonringer jonringer force-pushed the jonringer:bump-botan2 branch from 3e600f9 to 0fc1d2a Oct 3, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

still seems to be a regression

[9 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/3fzpm8ssl619bvbz1f535j72yz7gzld6-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/67480
1 package failed to build:
neopg

9 package were build:
biboumi botan botan2 kea monotone powerdns reposurgeon softhsm tlspool

I might just close this, neopg hasn't seen an update since april, and it's breaking on some of the botan's deprecation mechanisms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.