Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.DeviceSerialPort: name -> pname #67481

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@peterhoeg
Copy link
Member

commented Aug 26, 2019

Motivation for this change

My fix for the broken master wasn't quite as awesome as it should have been...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@peterhoeg peterhoeg merged commit 2b0098a into NixOS:master Aug 26, 2019
1 check was pending
1 check was pending
grahamcofborg-eval Checking original out paths
Details
@peterhoeg peterhoeg deleted the peterhoeg:f/perl branch Aug 26, 2019
@peterhoeg peterhoeg restored the peterhoeg:f/perl branch Aug 26, 2019
@peterhoeg peterhoeg deleted the peterhoeg:f/perl branch Aug 26, 2019
@volth

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

url is updated by bot and the mirror://cpan/authors/id/O/OW/OWNER/${pname}-${version}.tar.gz template is not stable on CPAN.

  • ${pname}-${version} sometimes replaced with ${pname}-v${version} and back
  • OWNER is not stable, the next version could have another OWNER

So I gave up supporting the templates in the bot and decided that
url = mirror://cpan/authors/id/C/CO/COOK/Device-SerialPort-1.04.tar.gz is good enough (and easier for the bot to parse)

@peterhoeg

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

This wasn't really supposed to happen. I was merging some stuff that had been lingering around, which accidentally broke master (the PR really should have been rebased).

Do you need me to change this back or will the bot take care of it?

@volth

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

Do you need me to change this back or will the bot take care of it?

bot will take care of it (unless it fails to parse ${pname})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.