Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport go updates to 19.03 #67485

Merged
merged 7 commits into from Aug 26, 2019

Conversation

@rvolosatovs
Copy link
Contributor

commented Aug 26, 2019

Motivation for this change

Refs #66894 (comment)
Cherry-picked all 1.11 and 1.12 go updates from master.
@kalbasit I was not sure if you wanted both versions to be backported or only 1.11.13 - did both, let me know if 1.12 changes should be removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kalbasit

dtzWill and others added 7 commits May 8, 2019
Co-authored-by: Diego Medina <fmpwizard@gmail.com>
@rvolosatovs

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@GrahamcOfBorg build go_1_11 go_1_12

@kalbasit

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

It's perfect, thank you @rvolosatovs

@kalbasit kalbasit merged commit e67da9e into NixOS:release-19.03 Aug 26, 2019
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
go, go_1_11, go_1_12 on aarch64-linux Success
Details
go, go_1_11, go_1_12 on x86_64-linux Success
Details
go_1_11, go_1_12 on aarch64-linux Success
Details
go_1_11, go_1_12 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@johanot johanot referenced this pull request Aug 27, 2019
5 of 10 tasks complete
@rvolosatovs rvolosatovs deleted the rvolosatovs:backport/go branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.