Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib: add getSchemaPath, makeSchemaPath #67488

Merged
merged 4 commits into from Aug 27, 2019

Conversation

@worldofpeace
Copy link
Member

commented Aug 26, 2019

Motivation for this change

Inspiration #67466 (comment)

Will update GNOME module to use this, but we should probably merge master into staging first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace requested a review from jtojnar Aug 26, 2019
@worldofpeace worldofpeace force-pushed the worldofpeace:glib/get-schema-path branch from f37bb6d to 98a9047 Aug 26, 2019
@ofborg ofborg bot requested review from hedning and etu Aug 26, 2019
@worldofpeace worldofpeace force-pushed the worldofpeace:glib/get-schema-path branch from 98a9047 to 7fabbba Aug 26, 2019
@ofborg ofborg bot requested a review from jtojnar Aug 26, 2019
@worldofpeace worldofpeace force-pushed the worldofpeace:glib/get-schema-path branch from 7fabbba to 7bb8f05 Aug 27, 2019
@ofborg ofborg bot requested a review from jtojnar Aug 27, 2019
@ofborg ofborg bot requested a review from jtojnar Aug 27, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Does this need to go to staging?

@jtojnar

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

I would say it does not but there is a merge conflict.

@worldofpeace

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

I would say it does not but there is a merge conflict.

Yeah, I'm probably too lazy for that. So off it goes 😊️

@worldofpeace worldofpeace merged commit 6402a04 into NixOS:staging Aug 27, 2019
14 of 16 checks passed
14 of 16 checks passed
glib on aarch64-linux
Details
glib on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
glib on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace worldofpeace deleted the worldofpeace:glib/get-schema-path branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.