Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiv2: enabling tests for real #67489

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@mmahut
Copy link
Member

commented Aug 26, 2019

Motivation for this change

Fixes #67453, which disabled all tests by mistake, given I have assumed doCheck defaults to true if tests are found.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Fixes #67453
Copy link
Member

left a comment

LGTM, as soon as the darwin check passes.

@mmahut

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

Looks like darwin is stuck.

@GrahamcOfBorg build exiv2

@mmahut

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

@worldofpeace now, the tests are failing on darwin instead of aarch64.

dyld: Library not loaded: Reason: image not found

@mmahut mmahut force-pushed the mmahut:exiv2 branch 2 times, most recently from 6a3e2cf to a63d342 Aug 26, 2019
@mmahut

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

@GrahamcOfBorg build exiv2

@mmahut mmahut force-pushed the mmahut:exiv2 branch from a63d342 to aeb5ad6 Aug 26, 2019
@mmahut

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

@GrahamcOfBorg build exiv2

@mmahut mmahut force-pushed the mmahut:exiv2 branch from aeb5ad6 to 3a19fe8 Aug 26, 2019
@mmahut

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

@GrahamcOfBorg build exiv2

Ok, last try and I disable the tests of darwin :)

@mmahut mmahut force-pushed the mmahut:exiv2 branch from 3a19fe8 to 4ee4bb9 Aug 26, 2019
@mmahut

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

@GrahamcOfBorg build exiv2

@mmahut mmahut merged commit bfcab98 into NixOS:master Aug 26, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
exiv2 on aarch64-linux Success
Details
exiv2 on x86_64-darwin Success
Details
exiv2 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.