Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
xxdiff: drop the old qt4 version in favour of qt5 #67498
Motivation for this change
We have been carrying the qt5 version for a long time (which works fine), so let's just drop the old qt4 variant. Also use the proper qt5
Because if we set
Because if we set ```sourceRoot```, only the ```src``` directory gets copied over to the build directory so we no longer have access to the README that needs copying in at install time.
This is not what is defined in `setup.sh`, and not what happens in practice if I set `sourceRoot` to be `source/src`
Additionally, we would have to patch the make files to not place the output in ```../bin```.
Ah right, writing outside `sourceRoot` is a problem as it is still read-only. But I guess this is what the comment should say, because right now it looks strange.
The README file is outside the source directory after it has been unpacked/copied over, but we can still get to it via
I've cleaned it up. Let me know what you think.
Unpack phase copies entire