Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme-obsidian2: 2.8 -> 2.9 #67501

Merged
merged 4 commits into from Aug 26, 2019

Conversation

@romildo
Copy link
Contributor

commented Aug 26, 2019

Motivation for this change

Update to version 2.9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@@ -2,21 +2,17 @@

stdenv.mkDerivation rec {
name = "theme-obsidian2-${version}";

This comment has been minimized.

Copy link
@peterhoeg

peterhoeg Aug 26, 2019

Member

Please change this to pname and drop the -${version} part.

This comment has been minimized.

Copy link
@romildo

romildo Aug 26, 2019

Author Contributor

Done.

postPatch = ''
sed -i -e 's|Obsidian-2-Local|Obsidian-2|' Obsidian-2/index.theme
'';

installPhase = ''

This comment has been minimized.

Copy link
@peterhoeg

peterhoeg Aug 26, 2019

Member

Please add runHook preInstall (and runHook postInstall at the end) when overriding the whole phase.

This comment has been minimized.

Copy link
@romildo

romildo Aug 26, 2019

Author Contributor

Done.

@@ -17108,6 +17108,8 @@ in
gtk = res.gtk2;
};

theme-obsidian2 = callPackage ../data/themes/obsidian2 { };

This comment has been minimized.

Copy link
@peterhoeg

peterhoeg Aug 26, 2019

Member

Any reason for the move?

This comment has been minimized.

Copy link
@romildo

romildo Aug 26, 2019

Author Contributor

Yes. There is an understanding that themes are best in the data category than in the misc one. New themes have been added there, and old themes are being moved when they are updated.

@peterhoeg peterhoeg merged commit 86e1452 into NixOS:master Aug 26, 2019
15 of 16 checks passed
15 of 16 checks passed
theme-obsidian2 on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
theme-obsidian2 on aarch64-linux Success
Details
theme-obsidian2 on x86_64-linux Success
Details
@romildo romildo deleted the romildo:upd.obsidian-2 branch Aug 26, 2019
peterhoeg added a commit to peterhoeg/nixpkgs that referenced this pull request Aug 27, 2019
* theme-obsidian2: 2.8 -> 2.9

* theme-obsidian2: move to pkgs/data

* theme-obsidian2: use pname

* theme-obsidian2: run hooks preInstall and postInstall in install phase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.