Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiled: use qt5.mkDerivation #67504

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@blargg
Copy link
Contributor

commented Aug 26, 2019

Motivation for this change

This updates the tiled package to use the new Qt package wrapQtAppsHook #65399. Without this, the program will fail on start up.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dywedir

@matthewbauer matthewbauer requested a review from ttuegel Aug 26, 2019
@ofborg ofborg bot requested a review from dywedir Aug 26, 2019
Copy link
Member

left a comment

LGTM, verified the binaries are wrapped.

See #65399
@worldofpeace worldofpeace force-pushed the blargg:fix/tiled branch from 582b94b to ff1839b Aug 26, 2019
@worldofpeace worldofpeace merged commit 8693002 into NixOS:master Aug 26, 2019
1 check was pending
1 check was pending
grahamcofborg-eval Cloning project
Details
@blargg blargg deleted the blargg:fix/tiled branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.