Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
python3Packages.pre-commit: 1.18.1 -> 1.18.2 #67509
Motivation for this change
jonringer left a comment
@FRidh when i run the pre-commit package in an environment with python27Packages.pre-commit (such as nix-review shell), i seem to be inheriting some of those packages even with a wrapped program. Should we just disallow receiving pythonpaths from environment as part of the wrapping process?
Yea, that's what i realized was happening, by default nix-review drops you into a nix-shell and my PYTHONPATH was inheriting ALL of the python packages.
I still think it would be nice to have a "isolated" python wrapping process which will insulate a given python application from receiving PYTHONPATH (such as unsetting it before the wrapper calls into the python application).