Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riot-desktop: use yarn2nix-moretea #67514

Conversation

@petabyteboy
Copy link
Contributor

commented Aug 26, 2019

Motivation for this change

Now that we have yarn2nix-moretea in the tree, we can use that instead of the vendored version that was introduced when yarn2nix was removed previously.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Now that we have yarn2nix-moretea in the tree, we can use that instead of the vendored version that was introduced when yarn2nix was removed previously.
@petabyteboy petabyteboy force-pushed the petabyteboy:feature/riot-desktop-yarn2nix-moretea branch from e35d30c to b840c96 Aug 26, 2019
@petabyteboy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@@ -1922,7 +1922,9 @@ in

ring-daemon = callPackage ../applications/networking/instant-messengers/ring-daemon { };

riot-desktop = callPackage ../applications/networking/instant-messengers/riot/riot-desktop.nix { };
riot-desktop = callPackage ../applications/networking/instant-messengers/riot/riot-desktop.nix {
yarn2nix = yarn2nix-moretea;

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Aug 26, 2019

Member

Please use yarn2nix-moretea directly.

@pacien

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Would using yarn.lock directly and letting yarn2nix generate yarn.nix automatically be allowed in nixpkgs? I'm not sure whether it would have an impact on the evaluation time, but it would simplify the maintenance of this package.

@petabyteboy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Would using yarn.lock directly and letting yarn2nix generate yarn.nix automatically be allowed in nixpkgs? I'm not sure whether it would have an impact on the evaluation time, but it would simplify the maintenance of this package.

It's not possible with Hydra (yet).

@pacien pacien referenced this pull request Aug 26, 2019
4 of 10 tasks complete
@pacien

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Ok, I added an update script as well in #67528.

@petabyteboy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

closing in favor of #67528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.