Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sway: 1.1.1 -> 1.2-rc2 #67515

Closed
wants to merge 1 commit into from

Conversation

@valebes
Copy link
Contributor

commented Aug 26, 2019

Motivation for this change

Update 1.1.1 -> 1.2-rc2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@valebes

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Waiting for 93b9e73

@alexarice

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

I was under the impression that we were sticking to full releases for sway

@alexarice

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

@valebes

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

Sorry, I've seen now.

@valebes valebes closed this Aug 27, 2019
@valebes valebes deleted the valebes:sway12 branch Aug 27, 2019
@VlivesRaw

This comment has been minimized.

Copy link

commented Aug 27, 2019

Just a touch too early :D Sway 1.2 is released, maybe @valebes you can create a new PR?

@valebes

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@VlivesRaw After merge c1d74a1 I'll take a look.

@primeos

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

FYI: I've already created #67554 ;)

@valebes

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

All right! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.