Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-up: 1.4.2 -> 1.6.1 #67517

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@jonringer
Copy link
Contributor

commented Aug 26, 2019

Motivation for this change

fixing @r-ryantm update failures.

bumped python2 to python3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peterhoeg

@peterhoeg

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Why not just change python2Packages to python3Packages?

@jonringer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

future proofing for python4.

Just kidding, but I've written enough python packages to not like know explicitly which version is being handed to me.

@peterhoeg

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@FRidh, do you prefer the derivation to be specific about the python version (python2Packages vs python3Packages), or simply to take a pythonPackages and then have all-packages.nix override accordingly?

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@GrahamcOfBorg build git-up

@ck3d
ck3d approved these changes Sep 28, 2019
Copy link
Contributor

left a comment

tested executable bin/git-up

@mmahut

This comment has been minimized.

Copy link
Member

commented Sep 28, 2019

Please fix the merge conflict.

@jonringer jonringer force-pushed the jonringer:bump-git-up branch from 16b71be to 90fabf5 Sep 28, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

commented Sep 28, 2019

@GrahamcOfBorg build git-up

rebased off master

Copy link
Contributor

left a comment

tested with nix-review, run nix-up on nixpkgs which failed with Failed to rebase upstream/release-18.09 onto 18.09 and then tested it on some other repos which worked ok.

@Lassulus Lassulus merged commit fe24628 into NixOS:master Oct 2, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
git-up on aarch64-linux Success
Details
git-up on x86_64-darwin Success
Details
git-up on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:bump-git-up branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.