Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.elpy: 1.28.0 -> 1.29.1 add tests #67518

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@costrouc
Copy link
Contributor

commented Aug 26, 2019

Motivation for this change

Latest version of elpy works with black

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@costrouc costrouc requested a review from FRidh as a code owner Aug 26, 2019
@costrouc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

nix-review passes

Result of nix-review pr 67518 1

2 package were build:
  • python27Packages.elpy
  • python37Packages.elpy
@costrouc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@GrahamcOfBorg build python3Packages.elpy python2Packages.elpy

@costrouc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Ready for merge.

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@GrahamcOfBorg build pythonPackages.elpy python3Packages.elpy

@costrouc costrouc force-pushed the costrouc:python-elpy-update branch from d870cae to 1d30da1 Aug 27, 2019
@costrouc

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@GrahamcOfBorg build python3Packages.elpy python2Packages.elpy

1 similar comment
@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@GrahamcOfBorg build python3Packages.elpy python2Packages.elpy

@mmahut mmahut merged commit 5a097da into NixOS:master Aug 27, 2019
15 of 16 checks passed
15 of 16 checks passed
python2Packages.elpy, python3Packages.elpy on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python2Packages.elpy, python3Packages.elpy on aarch64-linux Success
Details
python2Packages.elpy, python3Packages.elpy on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.