Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riot-desktop: use yarn2nix-moretea #67528

Closed
wants to merge 1 commit into from

Conversation

@pacien
Copy link
Contributor

commented Aug 26, 2019

Motivation for this change

Supersedes #67514 and adds a dependency update script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

adding a Yarn dependency update script
@petabyteboy

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

It should not be necessary to commit yarn.lock to nixpkgs.

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

It fails to execute for me with

Error launching app
Unable to find Electron app at /nix/store/yndjwq20a2kw5pnqizkb3z8m11gwg0k7-riot-desktop-1.3.3/share/riot/electron

Cannot find module '/nix/store/yndjwq20a2kw5pnqizkb3z8m11gwg0k7-riot-desktop-1.3.3/share/riot/electron'
Require stack:
- /nix/store/w37bnpxqdi31ycaza18w4wgx8w1gc89c-electron-5.0.8/lib/electron/resources/default_app.asar/main.js
- 
@petabyteboy

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Fix in #67534

@pacien

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Closing in favour of #67534.

@pacien pacien closed this Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.