Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove redundant rec #67530

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@volth
Copy link
Contributor

commented Aug 26, 2019

remove redundant rec

@volth

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@Mic92 the script is easy to rerun against the latest state of staging, so probably no need to solve merge conflicts manually

@Mic92

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

Do you know, why this triggers some rebuilds?

@volth

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

Do you know, why this triggers some rebuilds?

Mostly ruby modules with gemdir = ./.; and python modules with src = ./.;
ofborg report is here: https://gist.github.com/GrahamcOfBorg/e7efc582e944b04b20eb583bd766ed65

@volth volth force-pushed the volth:rec branch from 91e88e7 to 08f6831 Aug 28, 2019
@volth

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

rebased

@Mic92 Mic92 merged commit 7831d52 into NixOS:staging Aug 28, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Ericson2314

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.