Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tilt: 0.9.7 -> 0.10.4 #67532

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@jlesquembre
Copy link
Contributor

commented Aug 26, 2019

Motivation for this change

tilt: 0.9.7 -> 0.10.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @anton-dessiatov

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@GrahamcOfBorg build tilt

@jlesquembre

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@mmahut wasn't tilt already build? I thought every PR is using OfBorg automatically. I'm asking because I should have permissions to call GrahamcOfBorg build ..., so I could do it for the next PR

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@jlesquembre it did not build on darwin, given you are in the extra-known-users group, which allow you to build on x86_64 and aarch64. Darwin is little bit restricted, given the sandboxing is not working well on Mac OS X.

@mmahut mmahut merged commit 4b09f99 into NixOS:master Aug 27, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tilt on aarch64-linux Success
Details
tilt on x86_64-darwin Success
Details
tilt on x86_64-linux Success
Details
@jlesquembre

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@mmahut Understand, thanks for explaining it, I wasn't aware of that restriction

@jlesquembre jlesquembre deleted the jlesquembre:tilt branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.