Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riot-desktop: use yarn2nix-moretea #67534

Merged

Conversation

@petabyteboy
Copy link
Contributor

commented Aug 26, 2019

Now that we have yarn2nix-moretea in the tree, we can use that instead of the vendored version that was introduced when yarn2nix was removed previously. Also add an update script.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@petabyteboy petabyteboy referenced this pull request Aug 26, 2019
4 of 10 tasks complete
@ofborg ofborg bot requested a review from worldofpeace Aug 26, 2019
@pacien
pacien approved these changes Aug 26, 2019
Copy link
Contributor

left a comment

Looks good to me, thanks!

@petabyteboy petabyteboy force-pushed the petabyteboy:feature/riot-desktop-yarn2nix-moretea branch 2 times, most recently from afa3b88 to ccdbe3f Aug 26, 2019
@ofborg ofborg bot requested a review from worldofpeace Aug 26, 2019
Now that we have yarn2nix-moretea in the tree, we can use that instead of the vendored version that was introduced when yarn2nix was removed previously. Also add an update script.
@petabyteboy petabyteboy force-pushed the petabyteboy:feature/riot-desktop-yarn2nix-moretea branch from ccdbe3f to a9ae2c0 Aug 26, 2019
@worldofpeace worldofpeace merged commit 8a86654 into NixOS:master Aug 26, 2019
2 of 4 checks passed
2 of 4 checks passed
grahamcofborg-eval Beginning Evaluations
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg ofborg bot requested a review from worldofpeace Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.