Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.makam: init at 0.7.17 #67703

Closed
wants to merge 1 commit into from
Closed

Conversation

@teofr
Copy link
Contributor

@teofr teofr commented Aug 29, 2019

Motivation for this change

makam is a tool for rapid language prototyping. It's developed by Antonis Stampoulis.

The package is distributed through npm, so this is to have it easily installed in Nix.

More info: https://github.com/astampoulis/makam

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@gilligan
Copy link
Contributor

@gilligan gilligan commented Aug 30, 2019

Hey @teofr , congrats for making your first contribution to nixpkgs 👍 🎉
Could you please squash your 2 commits? No need to have the "fix" commit separately.

@teofr teofr force-pushed the teofr/nodejs-makam branch from 880ccb7 to ef95358 Aug 30, 2019
@teofr
Copy link
Contributor Author

@teofr teofr commented Aug 30, 2019

@gilligan thanks, I squashed the two commits.

@prusnak
Copy link
Member

@prusnak prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@ryantm
Copy link
Member

@ryantm ryantm commented Oct 16, 2020

merged via #100606

@ryantm ryantm closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants