Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.junit-xml: init at 1.8 #67730

Merged
merged 1 commit into from Jan 10, 2020
Merged

pythonPackages.junit-xml: init at 1.8 #67730

merged 1 commit into from Jan 10, 2020

Conversation

@multun
Copy link
Member

@multun multun commented Aug 29, 2019

Motivation for this change

This is needed to update python-sphinx.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@multun multun requested a review from FRidh as a code owner Aug 29, 2019
@multun multun changed the title junit-xml: init at 1.8 python: junit-xml: init at 1.8 Aug 30, 2019
@multun multun force-pushed the multun:junit_xml branch from bb4c8f4 to a95fc80 Aug 30, 2019
@FRidh
Copy link
Member

@FRidh FRidh commented Aug 31, 2019

@GrahamcOfBorg build python3.pkgs.junit-xml python2.pkgs.junit-xml

@wd15
Copy link
Contributor

@wd15 wd15 commented Sep 3, 2019

I'm not sure that a95fc80 has the correct message format. Should probably be pythonPackages.junit-xml: init at 1.8. Builds for me though.

Result of nix-review pr 67730 1

2 packages were built:
  • python27Packages.junit-xml
  • python37Packages.junit-xml
@multun multun force-pushed the multun:junit_xml branch from a95fc80 to ef1a41d Sep 3, 2019
@multun multun changed the title python: junit-xml: init at 1.8 pythonPackages.junit-xml: init at 1.8 Sep 3, 2019
@multun
Copy link
Member Author

@multun multun commented Sep 3, 2019

@wd15 fixed, thanks

@multun
Copy link
Member Author

@multun multun commented Sep 9, 2019

@FRidh would you mind having a look ? I'd like this to be merged before I try to land a new version of python-sphinx

@FRidh
Copy link
Member

@FRidh FRidh commented Sep 9, 2019

I can have a look but I do not intend to submit any newer sphinx until after the 19.09 release.

@FRidh
Copy link
Member

@FRidh FRidh commented Sep 9, 2019

@GrahamcOfBorg build python3.pkgs.junit-xml python2.pkgs.junit-xml

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@rvolosatovs rvolosatovs mentioned this pull request Sep 16, 2019
3 of 10 tasks complete
@rvolosatovs
Copy link
Contributor

@rvolosatovs rvolosatovs commented Oct 10, 2019

Can we get this merged? It's blocking #68947

@multun multun force-pushed the multun:junit_xml branch from ef1a41d to 6f38340 Dec 28, 2019
@multun multun requested a review from jonringer as a code owner Dec 28, 2019
@multun multun force-pushed the multun:junit_xml branch 2 times, most recently from 4365e52 to de0aafe Jan 2, 2020
@multun multun force-pushed the multun:junit_xml branch from de0aafe to 95e3a37 Jan 7, 2020
@multun multun force-pushed the multun:junit_xml branch from 95e3a37 to dcd2848 Jan 7, 2020
@multun
Copy link
Member Author

@multun multun commented Jan 7, 2020

@jonringer thanks for the review!

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commit LGTM
has test 👍

failure is upstream issue

[3 built (1 failed), 4 copied (0.1 MiB), 0.0 MiB DL]
error: build of '/nix/store/d6gcd17brp3cirzwnyp4css0ykql4w92-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/67730
1 package failed to build:
python38Packages.junit-xml

2 package built:
python27Packages.junit-xml python37Packages.junit-xml
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 10, 2020

@GrahamcOfBorg build python27Packages.junit-xml python37Packages.junit-xml

@jonringer jonringer merged commit 4a73922 into NixOS:master Jan 10, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.junit-xml, python37Packages.junit-xml on aarch64-linux Success
Details
python27Packages.junit-xml, python37Packages.junit-xml on x86_64-darwin Success
Details
python27Packages.junit-xml, python37Packages.junit-xml on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.