Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mplayer: 1.3.0 -> 1.4 #67733

Merged
merged 1 commit into from Sep 3, 2019
Merged

mplayer: 1.3.0 -> 1.4 #67733

merged 1 commit into from Sep 3, 2019

Conversation

@averelld
Copy link
Contributor

averelld commented Aug 29, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Aug 30, 2019

@GrahamcOfBorg build mplayer

@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Aug 30, 2019

Failures on aarch64:

vidix/sysdep/AsmMacros_x86.h:258:4: error: impossible constraint in 'asm'

@averelld averelld force-pushed the averelld:mplayer-upgrade branch from c43f8de to 67a09a7 Aug 30, 2019
@averelld

This comment has been minimized.

Copy link
Contributor Author

averelld commented Aug 30, 2019

Never worked on hydra, I've removed the platform.

@ofborg ofborg bot added the 8.has: clean-up label Aug 30, 2019
@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Aug 30, 2019

@GrahamcOfBorg build mplayer

Averell Dalton
@averelld averelld force-pushed the averelld:mplayer-upgrade branch from 67a09a7 to 37ca624 Aug 31, 2019
@aristidb aristidb merged commit ec57a12 into NixOS:master Sep 3, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@averelld averelld deleted the averelld:mplayer-upgrade branch Sep 3, 2019
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Sep 23, 2019
(cherry picked from commit ec57a12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.