Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.bisc: unmark as broken #67772

Merged
merged 1 commit into from Aug 30, 2019
Merged

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Aug 30, 2019

Motivation for this change

One of my little packages, seeing it broken breaks my heart.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files (just one)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't edit hackage-packages.nix. See the comment at the very top of the file.

  2. If you are certain that the package actually compiles, then remove it from the list of broken packages in pkgs/development/haskell-modules/configuration-hackage2nix.yaml and submit that change to the haskell-updates branch.

@rnhmjoj rnhmjoj changed the base branch from master to haskell-updates August 30, 2019 16:51
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Aug 30, 2019

Ah, I thought the broken attribute is determined at the generation of hackage-packages.nix and that it was ok to remove until the next one. Sorry.

If you are certain that the package actually compiles

Yes, it does: it broke on a recent update but then I fixed it.

@peti peti merged commit 446c780 into NixOS:haskell-updates Aug 30, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Aug 30, 2019

Thank you.

@rnhmjoj rnhmjoj mentioned this pull request Sep 2, 2019
10 tasks
@rnhmjoj rnhmjoj deleted the bisc branch September 14, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants