Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filebot: init at 4.8.5 #67849

Closed
wants to merge 1 commit into from
Closed

filebot: init at 4.8.5 #67849

wants to merge 1 commit into from

Conversation

@gleber
Copy link
Contributor

@gleber gleber commented Aug 31, 2019

Motivation for this change

This is a non-free application to rename downloaded media files as per internet databases of medias.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@gleber
Copy link
Contributor Author

@gleber gleber commented Aug 31, 2019

@GrahamcOfBorg build filebot

@gleber gleber force-pushed the gleber:add-filebot branch from 0276348 to 1140de3 Sep 1, 2019
@gleber
Copy link
Contributor Author

@gleber gleber commented Sep 1, 2019

@symphorien Addressed your comments, PTAL


nativeBuildInputs = [ makeWrapper autoPatchelfHook
# The following are lib dependencies for autoPatchelfHook to work.
stdenv.cc.cc.lib zlib libzen libmediainfo curlWithGnuTls libmms glib ];

This comment has been minimized.

@symphorien

symphorien Sep 3, 2019
Contributor

These should be buildInputs (runtime dependencies), not nativeBuildInputs (build dependencies).

# The following are lib dependencies for autoPatchelfHook to work.
stdenv.cc.cc.lib zlib libzen libmediainfo curlWithGnuTls libmms glib ];

buildPhase = '''';

This comment has been minimized.

@symphorien

symphorien Sep 3, 2019
Contributor

Suggested change
buildPhase = '''';
dontBuild = true;
ln -s $out/opt/filebot.sh $out/bin/filebot
'';

patchPhase = '''';

This comment has been minimized.

@symphorien

symphorien Sep 3, 2019
Contributor

Is this line really needed ?

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented May 4, 2020

ping @gleber, any update?

@gleber gleber force-pushed the gleber:add-filebot branch from 1140de3 to 67cbdae Jul 7, 2020
@ofborg ofborg bot added the 10.rebuild-linux: 1 label Jul 7, 2020
@felschr felschr mentioned this pull request Sep 6, 2020
4 of 10 tasks complete
@tomberek
Copy link
Contributor

@tomberek tomberek commented Sep 7, 2020

OBE. See above PR ^^^

@tomberek tomberek closed this Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.