Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wlrobs: init at tip #67897

Closed
wants to merge 1 commit into from
Closed

wlrobs: init at tip #67897

wants to merge 1 commit into from

Conversation

@jchv
Copy link
Contributor

@jchv jchv commented Sep 1, 2019

Motivation for this change

Allows OBS to capture the screen under some Wayland compositors. Tries to follow the pattern closely from the linuxbrowser plugin, including the comment at the top of the file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jchv jchv force-pushed the jchw-forks:add-wlrobs branch from 26c112b to 983a5f3 Sep 1, 2019
@jchv jchv force-pushed the jchw-forks:add-wlrobs branch from 40e97f5 to ab55022 Sep 10, 2019
@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@NilsIrl
Copy link
Contributor

@NilsIrl NilsIrl commented Jan 12, 2020

What's the difference with #70750?

If it's the same, this should probably be closed.

@jchv
Copy link
Contributor Author

@jchv jchv commented Jan 12, 2020

Looks the same. When I made this PR the other PR did not exist :) Thanks for pointing it out, though, and sorry to GrahamC for the slight bit of unnecessary duplicate work that probably could've been avoided.

@jchv jchv closed this Jan 12, 2020
@jchv jchv deleted the jchw-forks:add-wlrobs branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.