Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: unbreak cachix build #67914

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@marsam
Copy link
Contributor

marsam commented Sep 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam marsam requested a review from basvandijk as a code owner Sep 2, 2019
@marsam

This comment has been minimized.

Copy link
Contributor Author

marsam commented Sep 2, 2019

@GrahamcOfBorg build cachix

@cdepillabout

This comment has been minimized.

Copy link
Member

cdepillabout commented Sep 2, 2019

@marsam I believe the nixpkgs haskell maintainers generally don't want PRs to touch the pkgs/development/haskell-modules/hackage-packages.nix file. Could you remove your changes from this file?

(#67438 (comment))

@rnhmjoj

This comment has been minimized.

Copy link
Contributor

rnhmjoj commented Sep 2, 2019

I believe the nixpkgs haskell maintainers generally don't want PRs to touch the pkgs/development/haskell-modules/hackage-packages.nix file.

Can confirm. See #67772.

@marsam marsam force-pushed the marsam:unbreak-cachix branch from e7b9515 to 6a75db8 Sep 2, 2019
@marsam

This comment has been minimized.

Copy link
Contributor Author

marsam commented Sep 2, 2019

@cdepillabout, @rnhmjoj thanks for reviewing. I've addressed your comments.

@rnhmjoj
rnhmjoj approved these changes Sep 3, 2019
Copy link
Contributor

rnhmjoj left a comment

Looks good. I tried removing the broken attribute and it builds.

@cdepillabout

This comment has been minimized.

Copy link
Member

cdepillabout commented Sep 3, 2019

@Infinisil Infinisil merged commit 107d78b into NixOS:haskell-updates Sep 3, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.