Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby: 2.4.5 -> 2.4.7, 2.5.5 -> 2.5.6, 2.6.3 -> 2.6.4 #67976

Merged
merged 4 commits into from Sep 3, 2019

Conversation

@marsam
Copy link
Contributor

marsam commented Sep 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@petabyteboy

This comment has been minimized.

Copy link
Contributor

petabyteboy commented Sep 3, 2019

Should probably go to staging

@manveru
manveru approved these changes Sep 3, 2019
Copy link
Contributor

manveru left a comment

LGTM

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Sep 3, 2019

< 1000 packages should be fine for master, according to #nixos-dev.

08:44 andi-: qyliss: We had that discussion some time ago and someone came up with ~2500 as a "limit"
08:45 andi-: not sure who that was or if that is the final number but I've been trying to stick with it

@alyssais alyssais merged commit 3a601ca into NixOS:master Sep 3, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ruby, ruby_2_4, ruby_2_5, ruby_2_6 on aarch64-linux Success
Details
ruby, ruby_2_4, ruby_2_5, ruby_2_6 on x86_64-linux Success
Details
@petabyteboy

This comment has been minimized.

Copy link
Contributor

petabyteboy commented Sep 3, 2019

I see

@marsam marsam deleted the marsam:update-ruby branch Sep 3, 2019
@marsam marsam mentioned this pull request Dec 19, 2019
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.