Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver: 6.1.4 -> 6.1.5 #68000

Merged
merged 1 commit into from Sep 4, 2019
Merged

dbeaver: 6.1.4 -> 6.1.5 #68000

merged 1 commit into from Sep 4, 2019

Conversation

@jojosch
Copy link
Member

jojosch commented Sep 3, 2019

Motivation for this change

https://dbeaver.io/2019/08/18/dbeaver-6-1-5/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/6qdvd3k3gcwk6q4nlyf47mfv81vwrh46-dbeaver-ce-6.1.4	  984310544
/nix/store/y2cm10nawnxr4v3fsc0bn0w4wpf8rr5z-dbeaver-ce-6.1.5	  980274352
Notify maintainers

cc @samueldr

@samueldr

This comment has been minimized.

Copy link
Member

samueldr commented Sep 3, 2019

Hi, thanks for the update!

@jojosch do you want to take up maintainership of the dbeaver package? I stopped using it since my employment situation changed. I see you've lately been keeping it up to date, which is great 👍.

If you desire so, you can add yourself to the meta.maintainers attribute (after adding yourself to the maintainers-list). You can also remove my name from the list if add yourself. I will wait for an answer to this before merging.

If you have any questions, don't hesitate to ask.

@jojosch

This comment has been minimized.

Copy link
Member Author

jojosch commented Sep 3, 2019

If you desire so, you can add yourself to the meta.maintainers attribute (after adding yourself to the maintainers-list). You can also remove my name from the list if add yourself. I will wait for an answer to this before merging.

I opened a pull request (#68012) adding myself as a maintainer - will push an update here after the other pull request is merged.

Copy link
Contributor

aanderse left a comment

Tested connecting to a mssql database successfully. LGTM 👍

@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Sep 3, 2019

Would have been fine to add the maintainers commit to this PR as well (for reference to people of the future) -- but merged! :)

@jojosch jojosch force-pushed the jojosch:dbeaver_6.1.5 branch from 5a6da3c to 0c7fe83 Sep 3, 2019
@samueldr samueldr merged commit 65000c0 into NixOS:master Sep 4, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jojosch jojosch deleted the jojosch:dbeaver_6.1.5 branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.