Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnucash: fix build issue with newer CMake #68003

Closed
wants to merge 1 commit into from

Conversation

@mdorman
Copy link
Contributor

mdorman commented Sep 3, 2019

Motivation for this change

Fix gnucash's build break by incorporating a patch that has been accepted on upstream's maint branch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@aristidb

This comment has been minimized.

Copy link
Contributor

aristidb commented Sep 3, 2019

This has been independently fixed in a slightly different way in master. Please check which fix is better, if this one is nicer you can revert the other change and apply this one.

@jerith666

This comment has been minimized.

Copy link
Contributor

jerith666 commented Sep 4, 2019

the other fix is in #68026, FYI.

@mdorman mdorman closed this Oct 9, 2019
@mdorman mdorman deleted the mdorman:gnucash-cmake-fix branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.