Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

megacli: requireFile -> fetchurl #68006

Merged
merged 1 commit into from Sep 6, 2019
Merged

megacli: requireFile -> fetchurl #68006

merged 1 commit into from Sep 6, 2019

Conversation

@volth
Copy link
Contributor

volth commented Sep 3, 2019

Other distros use direct url (https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=megacli), so requireFile for a popular server package (used on many Hetzner servers) is an annoyance.

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Sep 3, 2019

And because it's unfree we don't cache the binary right?

@volth

This comment has been minimized.

Copy link
Contributor Author

volth commented Sep 3, 2019

caching is not needed, it is just unpack + patchelf

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Sep 3, 2019

Can you squash your two commits together? Should be fine, will merge.

@volth volth force-pushed the volth:patch-361 branch from 69ea3f4 to 31376b1 Sep 3, 2019
@roberth roberth merged commit 089011e into NixOS:master Sep 6, 2019
14 checks passed
14 checks passed
megacli on aarch64-linux No attempt
Details
megacli on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.